fix: add missing navigation properties to alternate key request builders #2541
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds appRoleAssignments() to ServicePrincipalsWithAppIdRequestBuilder and UsersWithUserPrincipalNameRequestBuilder. This addresses the gap where alternate key paths were missing standard navigation properties available on primary key paths. Closes microsoftgraph#2418
Contributor
|
@Ashutosh0x the command you issued was incorrect. Please try again. Examples are: and |
Author
|
@microsoft-github-policy-service agree company=skyhighsecurity |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This Pull Request addresses issue #2418 where alternate key request builders (specifically ServicePrincipalsWithAppIdRequestBuilder and UsersWithUserPrincipalNameRequestBuilder) were missing navigation methods (e.g., .appRoleAssignments()) that are standard on primary key paths.
Root Cause Analysis
The SDK is projected from OData metadata. While the AddAlternateKeyPaths setting in the metadata conversion pipeline generates the base paths for alternate keys, it currently does not recursively project sub-navigation properties for these paths.
Changes
Note to Maintainers
I am aware that these files are generated. However, this fix serves as a necessary bridge for Java users until the metadata/generator pipeline can be updated to handle alternate key navigation property propagation globally.
Closes #2418